Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sg cartridge folder #1042

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

zenit2001
Copy link
Contributor

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    Removing SG content from /cartridges folder as it's not part of src/ anymore
  • What existing problem does this pull request solve?
    SG will not be part of /cartridges folder.

Tested scenarios

Description of tested scenarios:

Fixed issue:

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@zenit2001 zenit2001 marked this pull request as ready for review January 31, 2024 09:51
@zenit2001 zenit2001 merged commit 6e62bc2 into develop Jan 31, 2024
13 of 15 checks passed
@zenit2001 zenit2001 deleted the improvement/remove-sg-cartridge-folder branch January 31, 2024 10:57
@zenit2001 zenit2001 added the refactor Refactors existing code label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactors existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants