Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace /sessions with /paymentMethods #1055

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

zenit2001
Copy link
Contributor

@zenit2001 zenit2001 commented Feb 26, 2024

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    Removal of /sessions from the cartridge.
  • What existing problem does this pull request solve?
    It replaces /sessions calls with /paymentMethods calls, in the following checkout flows:
    - End of Checkout
    - Express Checkout
    - Logged in user checkout

Tested scenarios

Description of tested scenarios:

  • Card payments
  • Redirect payments (iDeal, Klarna)
  • Single gift card payments
  • Multiple gift card payment + card
  • Logged in user end of checkout payment
  • Logged in user My Account add card
  • PayPal
  • UPI
  • CashApp
  • Bancontact
  • Apple Pay Express
  • Amazon Pay Express

Fixed issue: SFI-549

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zenit2001 zenit2001 changed the title Improvement/sfi 549 remove sessions Replace /sessions with /paymentMethods Feb 26, 2024
@zenit2001 zenit2001 added the refactor Refactors existing code label Feb 26, 2024
@zenit2001 zenit2001 marked this pull request as ready for review February 26, 2024 12:23
@zenit2001 zenit2001 merged commit f3f3430 into develop Feb 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactors existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants