Passing paypal line items #1069
Conversation
shanikantsingh
requested review from
maassenbas,
amihajlovski and
zenit2001
as code owners
zenit2001
changed the base branch from
main
to
feature/SFI-544-separate-cartridges
shanikantsingh
changed the base branch from
feature/SFI-544-separate-cartridges
to
develop
| function getLineItems({ Order: order, Basket: basket }) { | ||
| if (!(order || basket)) return null; | ||
| const orderOrBasket = order || basket; | ||
| const allLineItems = orderOrBasket.getProductLineItems(); |
There was a problem hiding this comment.
Do we want to pass shipping/promotions as line items? Similar we do for klarna and other open invoice methods?
There was a problem hiding this comment.
Can't we utilize and rename the current adyenOpenInvoiceData.js file for passing line items also to PayPal? This way we will not have duplicated code
We can possibly do something like function getLineItems({ Order: order, Basket: basket, addTaxPercentage, includeProperties = ['amountExcludingTax', 'taxAmount', ........... }), and conditionally pass the line items in adyenCheckout.js
| @@ -143,6 +144,11 @@ function createPaymentRequest(args) { | |||
| } | |||
| } | |||
|
|
|||
| //add line items for paypal | |||
| if (paymentRequest.paymentMethod.type.indexOf('paypal') > -1) { | |||
| paymentRequest.lineItems = paypalHelper.getLineItems(args); | |||
There was a problem hiding this comment.
If we decide to use adyenGetOpenInvoiceData.js then we can pass the line items here as follows:
args.includeProperties = ['amountExcludingTax', 'taxAmount', ......];
paymentRequest.lineItems = AdyenGetOpenInvoiceData.getLineItems(args);
shanikantsingh
force-pushed
the
feature/SFI-541_paypal_lineitems
branch
from
5995172
to
4edc344
Compare
|
Summary
Describe the changes proposed in this pull request:
Tested scenarios
Description of tested scenarios:
Fixed issue: #SFI-541