Added a check to set address properties in case they are available #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenit2001
requested review from
maassenbas,
amihajlovski and
shanikantsingh
as code owners
amihajlovski
previously approved these changes
Jun 11, 2024
|
shanikantsingh
approved these changes
Jun 11, 2024
src/cartridges/int_adyen_SFRA/cartridge/adyen/scripts/expressPayments/shippingMethods.js
Outdated
Show resolved
Hide resolved
amihajlovski
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the changes proposed in this pull request:
Address was being set to undefined. This was introduced in For Apple Pay express, the tax jurisdiction is now considered for tax calculation. #1079 , so it was not part of any previous release.
Makes sure the address is always defined when setting it.
Tested scenarios
Description of tested scenarios:
Fixed issue: SFI-800