HMAC Validation #914
Merged
HMAC Validation #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/cartridges/int_adyen_SFRA/cartridge/controllers/middlewares/adyen/notify.js
Show resolved
Hide resolved
src/cartridges/int_adyen_overlay/cartridge/scripts/checkNotificationAuth.js
Outdated
Show resolved
Hide resolved
src/cartridges/int_adyen_SFRA/cartridge/controllers/middlewares/adyen/notify.js
Show resolved
Hide resolved
src/cartridges/int_adyen_SFRA/cartridge/controllers/middlewares/adyen/notify.js
Outdated
Show resolved
Hide resolved
zenit2001
requested review from
maassenbas,
zaiddreakh and
shanikantsingh
as code owners
zaiddreakh
reviewed
May 24, 2023
src/cartridges/int_adyen_overlay/cartridge/scripts/checkNotificationAuth.js
Outdated
Show resolved
Hide resolved
zaiddreakh
previously approved these changes
May 25, 2023
amihajlovski
approved these changes
May 30, 2023
zaiddreakh
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the option of using HMAC validation to validate notifications coming from Adyen in SFRA architecture.