Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giftcard cancel button #944

Merged
merged 13 commits into from
Aug 11, 2023
Merged

Giftcard cancel button #944

merged 13 commits into from
Aug 11, 2023

Conversation

amihajlovski
Copy link
Contributor

@amihajlovski amihajlovski commented Aug 3, 2023

Summary

The cancel button is now moved at the bottom of the added giftcards list.
Rerendering is refactored and the logic now only initializes the checkout instead of fully rerendering payment methods.

@amihajlovski amihajlovski added the fix Fixes a bug label Aug 7, 2023
@amihajlovski amihajlovski marked this pull request as ready for review August 8, 2023 13:49
@amihajlovski amihajlovski changed the title Bugfix/giftcard cancel button Giftcard cancel button Aug 8, 2023
zenit2001
zenit2001 previously approved these changes Aug 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amihajlovski amihajlovski merged commit 301048b into develop Aug 11, 2023
14 of 17 checks passed
@amihajlovski amihajlovski deleted the bugfix/giftcard-cancel-button branch August 11, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants