Asynchronously rendering Apple Pay button #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amihajlovski
changed the title
amihajlovski
requested review from
maassenbas,
shanikantsingh and
zenit2001
as code owners
zenit2001
previously approved these changes
Aug 16, 2023
maassenbas
reviewed
Aug 17, 2023
src/cartridges/int_adyen_SFRA/cartridge/client/default/js/applePayExpress.js
Outdated
Show resolved
Hide resolved
src/cartridges/int_adyen_SFRA/cartridge/client/default/js/applePayExpress.js
Outdated
Show resolved
Hide resolved
src/cartridges/int_adyen_SFRA/cartridge/client/default/js/adyen_checkout/renderPaymentMethod.js
Outdated
Show resolved
Hide resolved
maassenbas
reviewed
Aug 18, 2023
...rtridges/int_adyen_SFRA/cartridge/client/default/js/adyen_checkout/renderGenericComponent.js
Show resolved
Hide resolved
shanikantsingh
previously approved these changes
Aug 18, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
zenit2001
approved these changes
Aug 21, 2023
shanikantsingh
approved these changes
Aug 22, 2023
amihajlovski
added a commit
that referenced
this pull request
Aug 22, 2023
* fix: show applepay button only on safari * fix: use isAvailable instead of regex * fix: check for isavailable in components * fix: update render method tests * fix: use applepay constant * fix: rounding amount value based on the currency decimals * fix: pow function
amihajlovski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the express option we can use the
isAvailableproperty that checkout offers, but not at the end of checkout.At the end of checkout we have to use regex and not render the payment method.