Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giftcards are being refunded in case of multiple gift cards being used in an order #970

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

amihajlovski
Copy link
Contributor

@amihajlovski amihajlovski commented Sep 25, 2023

Summary

Create one order for all partial payments

Fixed issue: SFI-406

@amihajlovski amihajlovski added the fix Fixes a bug label Sep 25, 2023
@amihajlovski amihajlovski changed the title Bugfix/giftcards refund Giftcards are being refunded in case of multiple gift cards being used in an order Sep 26, 2023
@amihajlovski amihajlovski marked this pull request as ready for review September 26, 2023 11:32
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shanikantsingh shanikantsingh merged commit 78edaf3 into develop Sep 28, 2023
14 of 17 checks passed
@shanikantsingh shanikantsingh deleted the bugfix/giftcards-refund branch September 28, 2023 08:43
amihajlovski added a commit that referenced this pull request Sep 28, 2023
…d in an order (#970)

* fix: use order data that was created once

* fix: remove adyenOrderData on giftcards removed

* fix: use latest orderData for doing the payment

* chore: rename function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants