Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFI-420] Amount per item is not populated in customer area for klarna #997

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

zenit2001
Copy link
Contributor

@zenit2001 zenit2001 commented Oct 27, 2023

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    The amount per item field in customer area it always populated as 0 when using klarna as payment method.
  • What existing problem does this pull request solve?
    This PR passes amountIncludingTax in the lineItemsObject, which correctly populates the amount per item field in customer area when klarna is being used.
    Also, in this PR taxCategory is removed as it is not part of checkout api v70.

Fixed issue: SFI-420

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zenit2001 zenit2001 changed the title [SFI-420] Amount per item is not populated in customer area [SFI-420] Amount per item is not populated in customer area for klarna Oct 27, 2023
@zenit2001 zenit2001 added the fix Fixes a bug label Oct 27, 2023
@zenit2001 zenit2001 marked this pull request as ready for review October 30, 2023 08:25
@shanikantsingh shanikantsingh merged commit 1eb1a6c into develop Oct 31, 2023
14 of 17 checks passed
@shanikantsingh shanikantsingh deleted the bugfix/SFI-420_amountperitem_klarna branch October 31, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants