-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECP-8326] Implement multiple giftcard usage #473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ECP-8327] Saving multiple Statedata
…are6 into ECP-8328 # Conflicts: # src/Controller/StoreApi/OrderApi/OrderApiController.php # src/Service/PaymentStateDataService.php
…are6 into ECP-8328 # Conflicts: # src/Controller/StoreApi/OrderApi/OrderApiController.php # src/Service/PaymentStateDataService.php
[ECP-8328] Refactor UI to support multiple giftcards
* ECP-8329 Creating GiftCard PM * ECP-8329 Creating GiftCard PM * ECP-8329 Creating GiftCard PM * ECP-8329 Creating GiftCard PM and refactoring code to show correct Payment Methods on the Shipping method listing and also correct summary on the summary block on confirm page * ECP-8329 Solving code sniffer issues * ECP-8329 Solving code sniffer issues * ECP-8329 removing debugging lines * ECP-8329 removing debugging lines
* ECP-8330 Refactor the payments call for multiple giftcards * ECP-8330 Refactor the payments call for multiple giftcards * ECP-8330 Refactor the payments call for multiple giftcards * ECP-8330 Solving sonarcloud issues * ECP-8330 Solving sonarcloud issues * ECP-8856 Shopware 6 - Compatibility Error on Update * ECP-8856 Shopware 6 - Compatibility Error on Update
…rd PM (#465) * ECP-9010 - Refactor MultiGiftcards UI and the flow for setting Giftcard PM * ECP-9010 - Refactor MultiGiftcards UI and the flow for setting Giftcard PM
…ed PaymentMethod files (#472)
peterojo
previously approved these changes
Apr 10, 2024
RokPopov
previously approved these changes
Apr 11, 2024
candemiralp
reviewed
Apr 15, 2024
khushboo-singhvi
dismissed stale reviews from RokPopov and peterojo
via
April 15, 2024 08:14
d3f2572
Removing comment as this was already addressed
Removing empty lines between phpDocs and construct
Using PHPDoc comments for type declarations and return value types
This is a public endpoint. Even though we are not using it in the headful version, it may be used in headless. Therefore adding deprecated tags instead of removing it
candemiralp
previously approved these changes
Apr 15, 2024
Solving pipeline issues - Removing space
Quality Gate passedIssues Measures |
candemiralp
approved these changes
Apr 15, 2024
RokPopov
approved these changes
Apr 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementing multiple giftcard support for Shopware 6 plugin.
This PR includes