Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-8326] Implement multiple giftcard usage #473

Merged
merged 35 commits into from
Apr 15, 2024

Conversation

[ECP-8327] Saving multiple Statedata
…are6 into ECP-8328

# Conflicts:
#	src/Controller/StoreApi/OrderApi/OrderApiController.php
#	src/Service/PaymentStateDataService.php
…are6 into ECP-8328

# Conflicts:
#	src/Controller/StoreApi/OrderApi/OrderApiController.php
#	src/Service/PaymentStateDataService.php
[ECP-8328] Refactor UI to support multiple giftcards
* ECP-8329 Creating GiftCard PM

* ECP-8329 Creating GiftCard PM

* ECP-8329 Creating GiftCard PM

* ECP-8329 Creating GiftCard PM and refactoring code to show correct Payment Methods on the Shipping method listing and also correct summary on the summary block on confirm page

* ECP-8329 Solving code sniffer issues

* ECP-8329 Solving code sniffer issues

* ECP-8329 removing debugging lines

* ECP-8329 removing debugging lines
* ECP-8330 Refactor the payments call for multiple giftcards

* ECP-8330 Refactor the payments call for multiple giftcards

* ECP-8330 Refactor the payments call for multiple giftcards

* ECP-8330 Solving sonarcloud issues

* ECP-8330 Solving sonarcloud issues

* ECP-8856 Shopware 6 - Compatibility Error on Update

* ECP-8856 Shopware 6 - Compatibility Error on Update
…rd PM (#465)

* ECP-9010 - Refactor MultiGiftcards UI and the flow for setting Giftcard PM

* ECP-9010 - Refactor MultiGiftcards UI and the flow for setting Giftcard PM
@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner April 4, 2024 07:47
peterojo
peterojo previously approved these changes Apr 10, 2024
RokPopov
RokPopov previously approved these changes Apr 11, 2024
src/Service/NotificationReceiverService.php Outdated Show resolved Hide resolved
src/Service/PaymentMethodsFilterService.php Show resolved Hide resolved
src/Service/PaymentStateDataService.php Outdated Show resolved Hide resolved
src/Service/PaymentStateDataService.php Outdated Show resolved Hide resolved
src/Storefront/Controller/FrontendProxyController.php Outdated Show resolved Hide resolved
src/Storefront/Controller/FrontendProxyController.php Outdated Show resolved Hide resolved
@khushboo-singhvi khushboo-singhvi dismissed stale reviews from RokPopov and peterojo via d3f2572 April 15, 2024 08:14
Removing comment as this was already addressed
Removing empty lines between phpDocs and construct
Using PHPDoc comments for type declarations and return value types
This is a public endpoint. Even though we are not using it in the headful version, it may be used in headless. Therefore adding deprecated tags instead of removing it
candemiralp
candemiralp previously approved these changes Apr 15, 2024
Solving pipeline issues - Removing space
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@khushboo-singhvi khushboo-singhvi merged commit 6154189 into develop Apr 15, 2024
12 checks passed
@RokPopov RokPopov added the Feature Indicates a new feature addition label Apr 17, 2024
@RokPopov RokPopov mentioned this pull request Apr 17, 2024
@candemiralp candemiralp deleted the feature/Multigiftcards branch May 14, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Indicates a new feature addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants