Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-9140] Disable individual gift card payment methods #477

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Conversation

candemiralp
Copy link
Member

@candemiralp candemiralp commented Apr 16, 2024

Summary

After implementing multiple gift card payments in PR #473, old gift card payment methods became redundant.

This PR cleans up the following gift card payment methods. Note that, multiple gift card implementation PR introduces a new payment method Adyen GiftCard for all of the gift cards.

Tested scenarios

  • Gift card payment flow

@candemiralp candemiralp requested a review from a team as a code owner April 16, 2024 14:47
@candemiralp candemiralp marked this pull request as draft April 16, 2024 14:47
@candemiralp candemiralp marked this pull request as ready for review April 16, 2024 15:17
RokPopov
RokPopov previously approved these changes Apr 16, 2024
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.8% Duplication on New Code

See analysis details on SonarCloud

@RokPopov RokPopov mentioned this pull request Apr 17, 2024
@RokPopov RokPopov merged commit bb60bd1 into develop Apr 18, 2024
12 checks passed
@RokPopov RokPopov deleted the ECP-9140 branch April 18, 2024 07:54
@candemiralp candemiralp added the Fix Indicates a bug fix label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants