-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ACH not respecting showPayButton #2696
Conversation
🦋 Changeset detectedLatest commit: 0ef1515 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +13.9 kB (+1.21%) Total Size: 1.16 MB
|
packages/lib/src/components/internal/RedirectButton/RedirectButton.tsx
Outdated
Show resolved
Hide resolved
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Summary
ACH and some other stored payment methods do not respect
showPayButton
config.This hopefully fixes that by moving the responsibility to the RedirectButton component. Together with that there's a small CSS fix to ensure we don't display extra bottom margins if there's no content.
Tested scenarios
showPayButton
falseFixed issue:
#2554