Bacs Direct Debit component #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.75 kB (1%) Total Size: 128 kB
|
|
This pull request introduces 1 alert when merging 08b2700 into b39291a - view on LGTM.com new alerts:
|
marcperez
reviewed
Dec 8, 2020
marcperez
reviewed
Dec 8, 2020
Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com>
Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com>
Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com>
Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com>
Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com>
Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com>
# Conflicts: # packages/lib/src/components/BacsDD/components/BacsInput.scss
Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com>
…shown in the time between submitting the payment and the action being handled
marcperez
reviewed
Dec 9, 2020
marcperez
reviewed
Dec 9, 2020
marcperez
approved these changes
Dec 10, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
pabloai
pushed a commit
that referenced
this pull request
Dec 30, 2020
* BacsDD - first draft * Validating holderName, bankAccount number & shopperEmail * Added bankLocationId field * Added checkbox validation * Added second 'confirm' state, class names and aria attributes * Added 'Edit' button to confirm page * Hide valid ticks on confirm page * Fixed validation rules for email and name (return object is same as for other rules) * BacsDD calls setStatus on BacsInput to trigger re-render * Added prop to interface * BacsResult (voucher) - first draft * Adjusted styling on result * Latest files so we can make a Draft PR * Adjusted input widths for bankAccount and locationId * Removed billingAddress from /payments call now that API has been updated * Added lock icon and amount to pay button * BacsDD removing preSubmit function & own PayButton * BacsDD cleaning up state & status change mechanism * BacsDD cleaning up render method * changed error msg text * Internalising state into the BacsInput comp * Removed checks for undefined status * Add Bacs to the vouchers playground * BacsInput uses hook to store local isValid state * removed unnecessary return * Added possibility to specify text on Voucher download button * Fixing CI error * Fix ConsentCheckbox on Bacs Component * Fixing CI error * Added translation keys * Add bacs to components playground * Merging changes from master * Can now make payment when component is standalone * Removed BacsResult.scss (not needed after merge from master) * Restoring BacsInput.scss and removing BacsResult.scss * Update packages/lib/src/components/BacsDD/components/BacsInput.scss Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com> * Update packages/lib/src/components/BacsDD/components/BacsInput.scss Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com> * Update packages/lib/src/components/BacsDD/components/BacsInput.scss Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com> * Update packages/lib/src/components/BacsDD/components/BacsInput.scss Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com> * Update packages/lib/src/components/BacsDD/components/BacsInput.scss Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com> * Update packages/lib/src/components/BacsDD/components/BacsInput.scss Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com> * Restoring BacsResult.scss and using .scss vars * Restoring BacsResult.scss and using .scss vars (post merge) * Update packages/lib/src/components/BacsDD/components/BacsInput.scss Co-authored-by: Marc Pérez <marc.pereziribas@adyen.com> * Fixed UI flash when Pay pressed. The form, in an editable state, was shown in the time between submitting the payment and the action being handled * BacsDD.tsx overrides UIElement.payButton * Restoring original ThreeDS2Challenge.tsx error message * Adding bacsResult to Voucher playground * First tests for BacsInput.tsx * First tests for BacsInput.tsx (added to PR) * Removed unused imports Co-authored-by: marcp <marc.pereziribas@adyen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementing the Bacs Direct Debit components (directdebit_GB)
Tested scenarios
Fixed issue: COWEB-808