Feature/using cvc policy #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… callbacks re. PLCCs
…LCCs (as a reference)
…ans for certain values (e.g. enableLuhnCheck)
…olicy' to use this to register a brand change
# Conflicts: # packages/e2e/tests/cards/branding/branding.test.js # packages/lib/src/components/Card/components/CardInput/CardInput.tsx # packages/lib/src/components/Card/components/CardInput/handlers.ts # packages/lib/src/components/Card/components/CardInput/processBinLookup.ts # packages/lib/src/components/Card/triggerBinLookUp.ts # packages/lib/src/components/Card/types.ts # packages/lib/src/components/internal/SecuredFields/SecuredFieldsProvider.test.tsx # packages/lib/src/components/internal/SecuredFields/SecuredFieldsProvider.ts # packages/lib/src/components/internal/SecuredFields/SecuredFieldsProviderHandlers.ts # packages/lib/src/components/internal/SecuredFields/lib/core/handleValidation.ts # packages/lib/src/components/internal/SecuredFields/lib/core/utils/handleBrandFromBinLookup.ts # packages/lib/src/components/internal/SecuredFields/lib/types.ts
… of regular card and PLCC
…ew CardInput validation procedure
sponglord
requested review from
marcperez,
pabloai and
shernaz
as code owners
|
Size Change: +196 B (0%) Total Size: 146 kB
|
|
This pull request introduces 1 alert when merging a725f7d into 1a87f27 - view on LGTM.com new alerts:
|
marcperez
reviewed
Feb 1, 2021
marcperez
reviewed
Feb 1, 2021
packages/lib/src/components/internal/SecuredFields/lib/utilities/commonUtils.ts
Outdated
Show resolved
Hide resolved
marcperez
approved these changes
Feb 1, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/binLookupand it's use of acvcPolicy- refactorCard&SecuredFieldcode to drop the separatecvcRequired&hideCVCproperties and instead use acvcPolicyprop which can cover all scenarios.CardInputto trigger validation - validating "every time there's a change in state" rather than "validating every time we set the state"v3.3.0Tested scenarios
All tests, unit & e2e, run and pass