Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Update release config to create draft Github releases #133

Merged
merged 1 commit into from
Jan 17, 2023
Merged

🔧 Update release config to create draft Github releases #133

merged 1 commit into from
Jan 17, 2023

Conversation

joao-m-santos
Copy link
Contributor

Relates to #122

📝 Description

Change release-it config to create draft GitHub release instead of a proper one

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos requested a review from a team as a code owner January 12, 2023 08:56
@joao-m-santos joao-m-santos self-assigned this Jan 12, 2023
@netlify
Copy link

netlify bot commented Jan 12, 2023 •
edited
Loading

✅ Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit cf6caba
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/63bfcb5089a8670008e1e924
😎 Deploy Preview https://deploy-preview-133--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joao-m-santos joao-m-santos merged commit 7a7bb35 into main Jan 17, 2023
@joao-m-santos joao-m-santos mentioned this pull request Jan 18, 2023
Merged
@joao-m-santos joao-m-santos deleted the 122-update-release-it-config branch February 1, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivy27 vivy27 vivy27 approved these changes

Assignees

@joao-m-santos joao-m-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joao-m-santos @vivy27