Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 Update typography styles #15

Merged
merged 2 commits into from
Oct 10, 2022
Merged

💄 Update typography styles #15

merged 2 commits into from
Oct 10, 2022

Conversation

joao-m-santos
Copy link
Contributor

@joao-m-santos joao-m-santos commented Oct 10, 2022 •
edited by vivy27
Loading

Relates to #DV-53 (YouTrack)

📝 Description

Updated all typography variables
Added typography mixins for font size/weight/line-height
Updated text colors for all chart elements

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos self-assigned this Oct 10, 2022
@joao-m-santos joao-m-santos requested a review from a team as a code owner October 10, 2022 09:40
@joao-m-santos joao-m-santos mentioned this pull request Oct 10, 2022
Closed
@joao-m-santos joao-m-santos merged commit 4c297dd into main Oct 10, 2022
@joao-m-santos joao-m-santos deleted the typography branch February 1, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivy27 vivy27 vivy27 approved these changes

Assignees

@joao-m-santos joao-m-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joao-m-santos @vivy27