Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mr/main/lucasv/changing the case for consts in lume bar chart #89

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Mr/main/lucasv/changing the case for consts in lume bar chart #89

merged 4 commits into from
Nov 21, 2022

Conversation

Lucas1981
Copy link
Contributor

Relates to #

📝 Description

Add a brief description

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Lucas1981 Lucas1981 requested a review from a team as a code owner November 21, 2022 12:56
@netlify
Copy link

netlify bot commented Nov 21, 2022 •
edited
Loading

✅ Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit eb806e7
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/637ba081205ab3000934e8b4
😎 Deploy Preview https://deploy-preview-89--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

joao-m-santos
joao-m-santos previously approved these changes Nov 21, 2022
View reviewed changes
@vivy27 vivy27 force-pushed the mr/main/lucasv/changing-the-case-for-consts-in-lume-bar-chart branch from f4e4384 to 61f8d9f Compare November 21, 2022 15:21
@Lucas1981 Lucas1981 force-pushed the mr/main/lucasv/changing-the-case-for-consts-in-lume-bar-chart branch from 61f8d9f to 03a961f Compare November 21, 2022 15:57
@Lucas1981 Lucas1981 merged commit ef686f0 into main Nov 21, 2022
@joao-m-santos joao-m-santos deleted the mr/main/lucasv/changing-the-case-for-consts-in-lume-bar-chart branch February 1, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joao-m-santos joao-m-santos joao-m-santos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucas1981 @joao-m-santos