Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing when picking language #132

Merged
merged 1 commit into from Sep 22, 2019
Merged

Fix crashing when picking language #132

merged 1 commit into from Sep 22, 2019

Conversation

scx
Copy link

@scx scx commented Sep 1, 2019

Aegisub crashes immediately after selecting any language from the end of the list (above the 100th position).
This is because it can support no more than 100 languages.
This patch extends this limit up to 1000 languages (locales).

Fixes #131


Test results from my system.

Number of dictionaries:

$ find /usr/share/myspell/ -xtype f -iname '*.dic' -exec printf %.0s. {} + | wc -m
242

Number of thesaurus:

$ find /usr/share/myspell/ -xtype f -iname '*.aff' -exec printf %.0s. {} + | wc -m
242

Number of languages:

$ cat <( find /usr/share/myspell/ -xtype f -iname '*.dic' -exec printf %.0s. {} + | wc -m ) <( find /usr/share/myspell/ -xtype f -iname '*.aff' -exec printf %.0s. {} + | wc -m ) | sort -nr | head -n 1
242

Number of locales:

locale -a | wc -l
791

See also:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935724#10
https://bugs.launchpad.net/ubuntu/+source/aegisub/+bug/1841381/comments/2

Aegisub crashes immediately after selecting any language
from the end of the list (above the 100th position).
This is because it can support no more than 100 languages.
This patch extends this limit up to 1000 languages (locales).

Fixes Aegisub#131
@tgoyne tgoyne merged commit 547b17f into Aegisub:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aegisub crashes immediately after selecting any language from the end of the list
2 participants