Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler flags #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compiler flags #136

wants to merge 1 commit into from

Conversation

scx
Copy link

@scx scx commented Sep 8, 2019

@tgoyne
Copy link
Member

tgoyne commented Sep 22, 2019

This appears to result in release builds being built without optimizations enabled.

@scx
Copy link
Author

scx commented Sep 23, 2019

There is also a problem with Clang-specific flags, like -Wno-sometimes-uninitialized or -Wno-c++11-narrowing.
Maybe we should do some checks and pass -Wno-narrowing to GCC and -Wno-c++11-narrowing to Clang?

@samoht0 samoht0 mentioned this pull request Jan 28, 2021
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scx @tgoyne