Add close button #62
Closed
Add close button #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using a tiling window manager we don't have decorations, and then no X button. so i added a close button to the Main/Character and DBEditor window
seems to be a linux/windows difference
|
Hi qeqar, vielen Dank für den PR! Ich denke aber UX-wise wäre es eher schlechtes Design, einen Button einzufügen, der für 99% der User überflüssig ist. Daher würde ich vorschlagen: Du fügst den Button dynamisch zur Laufzeit ein, aber nur falls der user einen tiling window manager nutzt (leider keine Ahnung wie man das überprüft). Alternativ kannst du natürlich einfach deinen Fork nutzen und regelmäßig updaten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using a tiling window manager we don't have decorations, and no X button.
so i added a close button to the Main/Character and DBEditor window