Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

Fix typos in gym-related messages #112

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Fix typos in gym-related messages #112

merged 1 commit into from
Nov 6, 2016

Conversation

laverdet
Copy link
Contributor

Some nitpicky typos here that bit me.

@laverdet
Copy link
Contributor Author

Actually all the battle-related messages are in pretty bad shape. I'll resubmit when I have something fully working.

@laverdet laverdet closed this Jul 31, 2016
@laverdet
Copy link
Contributor Author

laverdet commented Aug 2, 2016

Nevermind, this PR is actually good. I've gotten gym battles working correctly with the existing message format, the only wrong is the misleading attribute names fixed in this patch.

@laverdet laverdet reopened this Aug 2, 2016
@rubenvereecken
Copy link
Contributor

If you don't mind I'm going to try and keep this one for v2.0, or whatever version I dare use for breaking refactorings.

@laverdet
Copy link
Contributor Author

laverdet commented Aug 2, 2016

Sure.

@Nihisil Nihisil mentioned this pull request Aug 4, 2016
Open
@laverdet laverdet force-pushed the master branch 2 times, most recently from 65b31cb to dd80030 Compare August 16, 2016 04:40
@AeonLucid AeonLucid closed this Nov 6, 2016
@laverdet
Copy link
Contributor Author

laverdet commented Nov 6, 2016

Hey this one is actually still relevant ;)

@AeonLucid AeonLucid reopened this Nov 6, 2016
@AeonLucid AeonLucid merged commit 13dcce8 into AeonLucid:master Nov 6, 2016
@AeonLucid
Copy link
Owner

Thanks @laverdet 👍

@XueweiHan
Copy link

Sorry, not sure is this the right place to ask question?
I think I can successfully start a gym battle, but I don't know how to send battle actions. I always get invalid battle actions response. Can you help to understand which field I need to fill for the BattleAction?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laverdet @rubenvereecken @AeonLucid @XueweiHan