CI TEST - DO NOT MERGE

.flake8

@@ -3,4 +3,4 @@ max-line-length = 120
 ignore = E203, E266, E501, W503, F403, F401, C901, W605
 max-complexity = 20
 select = B,C,E,F,W,T4,B9
-exclude = .idea,.git,__pycache__,sphinx,.venv*,.venv,venv,docs/*,benchmarks/*
+exclude = .idea,.git,__pycache__,sphinx,.venv*,.venv,venv,docs/*,benchmarks/*,*.pyx,*pxd,*.pxi

.github/workflows/build_wheels.yml

@@ -0,0 +1,58 @@
+name: Build
+
+on: [pull_request]
+
+jobs:
+  build_wheels:
+    name: Build wheels on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up QEMU
+        if: runner.os == 'Linux'
+        uses: docker/setup-qemu-action@v3
+        with:
+          platforms: all
+
+      - name: Build wheels
+        uses: pypa/cibuildwheel@v2.16.5
+
+      - uses: actions/upload-artifact@v4
+        with:
+          name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}
+          path: ./wheelhouse/*.whl
+
+  make_sdist:
+    name: Make SDist
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Build SDist
+        run: pipx run build --sdist
+
+      - uses: actions/upload-artifact@v4
+        with:
+          name: cibw-sdist
+          path: dist/*.tar.gz
+
+  upload_all:
+    needs: [build_wheels, make_sdist]
+    environment: pypi
+    permissions:
+      id-token: write
+    runs-on: ubuntu-latest
+    if: github.event_name == 'release' && github.event.action == 'published'
+    steps:
+    - uses: actions/download-artifact@v4
+      with:
+        pattern: cibw-*
+        path: dist
+        merge-multiple: true
+
+    - uses: pypa/gh-action-pypi-publish@release/v1

.github/workflows/debug_tests.yml

@@ -1,6 +1,6 @@
 name: Run tests for debugging sigabrt
 
-on: [pull_request]
+#on: [pull_request]
 
 jobs:
 

.github/workflows/documentation.yml

@@ -1,11 +1,11 @@
 name: Documentation
 
-on:
-  push:
-    branches:
-      - develop
-  pull_request:
-  release:
+#on:
+#  push:
+#    branches:
+#      - develop
+#  pull_request:
+#  release:
 
 jobs:
   build:

.github/workflows/test_linux_with_coverage.yml

@@ -1,6 +1,6 @@
 name: Code coverage
 
-on: [pull_request]
+#on: [pull_request]
 
 jobs:
   testing:

.github/workflows/unit_tests.yml

@@ -1,6 +1,6 @@
 name: Tests on all platforms with linting
 
-on: [pull_request]
+#on: [pull_request]
 
 jobs:
   linting:

aequilibrae/paths/AoN.pyx

@@ -241,19 +241,20 @@ def path_computation(origin, destination, graph, results):
                                     original_b_nodes_view)
 
         if a_star_bint:
-            w = path_finding_a_star(origin_index,
-                                    dest_index,
-                                    g_view,
-                                    b_nodes_view,
-                                    graph_fs_view,
-                                    nodes_to_indices_view,
-                                    lat_view,
-                                    lon_view,
-                                    predecessors_view,
-                                    ids_graph_view,
-                                    conn_view,
-                                    reached_first_view,
-                                    heuristic)
+            path_finding_a_star(
+                origin_index,
+                dest_index,
+                g_view,
+                b_nodes_view,
+                graph_fs_view,
+                nodes_to_indices_view,
+                lat_view,
+                lon_view,
+                predecessors_view,
+                ids_graph_view,
+                conn_view,
+                heuristic
+            )
         else:
             w = path_finding(origin_index,
                              dest_index if early_exit_bint else -1,
@@ -266,7 +267,7 @@ def path_computation(origin, destination, graph, results):
                              reached_first_view)
 
 
-        if skims > 0:
+        if skims > 0 and not a_star_bint:
             skim_single_path(origin_index,
                              nodes,
                              skims,

aequilibrae/paths/basic_path_finding.pyx

@@ -224,7 +224,7 @@ cdef void skim_single_path(long origin,
 
     # Zeroes the intrazonal cost
     for j in range(skims):
-            node_skims[origin, j] = 0
+        node_skims[origin, j] = 0
 
     # Cascade skimming
     for i in range(1, found + 1):
@@ -420,7 +420,7 @@ cdef inline double equirectangular_heuristic(double lat1, double lon1, double la
 @cython.wraparound(False)
 @cython.embedsignature(True)
 @cython.boundscheck(False)
-cpdef int path_finding_a_star(long origin,
+cpdef void path_finding_a_star(long origin,
                               long destination,
                               double[:] graph_costs,
                               long long [:] csr_indices,
@@ -431,7 +431,6 @@ cpdef int path_finding_a_star(long origin,
                               long long [:] pred,
                               long long [:] ids,
                               long long [:] connectors,
-                              long long [:] reached_first,
                               Heuristic heuristic) noexcept nogil:
     """
     Based on the pseudocode presented at https://en.wikipedia.org/wiki/A*_search_algorithm#Pseudocode
@@ -451,7 +450,6 @@ cpdef int path_finding_a_star(long origin,
         ElementState vert_state  # vertex state
         size_t origin_vert = <size_t>origin
         size_t destination_vert = <size_t>destination if destination != -1 else 0
-        ITYPE_t found = 0
         double *gScore = <double *>malloc(M * sizeof(double))
 
     cdef:
@@ -473,7 +471,6 @@ cpdef int path_finding_a_star(long origin,
     for i in range(M):
         pred[i] = -1
         connectors[i] = -1
-        reached_first[i] = -1
         gScore[i] = INFINITY
 
     # initialization of the heap elements
@@ -488,8 +485,6 @@ cpdef int path_finding_a_star(long origin,
     # main loop
     while pqueue.size > 0:
         current = extract_min(&pqueue)
-        reached_first[found] = current
-        found += 1
 
         if current == destination_vert:
             break
@@ -515,4 +510,3 @@ cpdef int path_finding_a_star(long origin,
 
     free_heap(&pqueue)
     free(gScore)
-    return found - 1