Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup.cfg migration and CI with Travis #30

Closed
wants to merge 1 commit into from

Conversation

jorgepiloto
Copy link
Member

I thought it would be interesting to migrate to a setup.cfg file. In addition, I added a small .travis.yml file so we could apply some kind of CI to the project. My experience with this kind of files is limited, so it would be nice someone else to make an small review of them.

Also, some extra requirements are added to the setup-cfg file in order documentation be compiled in read the docs ☺️

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments!

setup.cfg Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
],
long_description=open('README.rst').read()
)
setup(setup_cfg=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is setup_cfg=True needed?

setup.cfg Outdated Show resolved Hide resolved
src/skaero/__init__.py Outdated Show resolved Hide resolved
src/skaero/util/decorators.py Outdated Show resolved Hide resolved
Add travis for CI

Add src layout

Improve setup.cfg and apply isort


Add installation requirements to travis


Add sudo false


Move to Python 3

Improve setup.cfg

Update travis configuration

Apply black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants