Minor fixes #3
Merged
Minor fixes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sum of char_width might be longer than String.len() which could be more than usize
When there is an overflow the code is wrong. Notice that more actively.
Merged
Aetf
pushed a commit
that referenced
this pull request
Apr 27, 2024
## 🤖 New release * `unicode-truncate`: 0.2.0 -> 1.0.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> It's about time for a 1.0 release. This crate has been stable over the years. ### Breaking changes Formally define MSRV (minimum supported rust version) to `1.63`. ### Added - new method `unicode_truncate_centered`. Thanks @EdJoPaTo (#2, #3) ### Fixed - prevent arithmetic side effects ([#7](#7)) - do not include zero-width characters at boundaries when truncate_start ### Other - use release-plz - use renovate (#4) - move from Travis to Github Action - update Rust crate criterion to 0.5 ([#5](#5)) - fix broken links - Check in Cargo.lock per the latest guide </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2