-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): more reviews can be loaded with a see more button #194
Merged
davidlhw
merged 12 commits into
main
from
144-featui-infinite-scrolling-for-review-section
Sep 1, 2024
Merged
feat(ui): more reviews can be loaded with a see more button #194
davidlhw
merged 12 commits into
main
from
144-featui-infinite-scrolling-for-review-section
Sep 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) See more button added which loads an additional 10 reviews after initial 10 2) New component (LoadMoreReviews) added to handle additional reviews 3) Misc: Changed reviews.json to have identifiable text to distinguish between reviews
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Still haven't cleared the bugs and the "check in view" is still not cleaned/working
This reverts commit d00779f.
davidlhw
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the PR! :)
changes mostly look great, just a couple of minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New user-facing feature or request. This Label is used as a category on release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #144
Context
Previously, there's no way for users to load more reviews than what is initially loaded. This change adds the functionality through a see more button.
Changes
See more button added which loads an additional 10 reviews after initial 10
New component (LoadMoreReviews) added to handle additional reviews
Misc: Changed reviews.json to have identifiable text to distinguish between reviews
Implementation Details
How to Test
On the main page, can scroll to the button and click See More, you will see 10 more reviews loaded
Checklist