Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): courses trpc router #77

Merged
merged 2 commits into from
Apr 27, 2024
Merged

feat(api): courses trpc router #77

merged 2 commits into from
Apr 27, 2024

Conversation

davidlhw
Copy link
Contributor

@davidlhw davidlhw commented Mar 30, 2024 •
edited
Loading

closes #70

Changes

  • add courses trpc router
  • add listByUni public endpoint
  • add listByFaculty public endpoint
  • add listByUni protected endpoint
  • add listByFaculty protected endpoint
  • example implemenation

Testing

  1. setup local dev env
    a. run docker compose up
    b. run npx prisma migrate reset to setup and seed the local db
  2. navigate to /
  3. sign in if needed
  4. should see 10 courses from both private and protected endpoints. Private endpoint data should show more fields than public endpoint data

@vercel Vercel
Copy link

vercel bot commented Mar 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
afterclass-io-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 10:11am

@davidlhw davidlhw linked an issue Mar 30, 2024 that may be closed by this pull request
[BE] API Endpoint for course data by course id #70
Closed
@davidlhw davidlhw self-assigned this Mar 31, 2024
@davidlhw davidlhw changed the base branch from feat/reviews-endpoint to main April 16, 2024 10:10
Jaylin0312
Jaylin0312 reviewed Apr 27, 2024
View reviewed changes
Copy link
Contributor

@Jaylin0312 Jaylin0312 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left a small comment for discussion

src/app/(school)/page.tsx Show resolved Hide resolved
Jaylin0312
Jaylin0312 approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@Jaylin0312 Jaylin0312 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM, tested and working on local machine

@davidlhw davidlhw merged commit 168f6a7 into main Apr 27, 2024
5 checks passed
@davidlhw davidlhw deleted the feat/courses-endpoint branch April 27, 2024 09:23
@davidlhw davidlhw mentioned this pull request May 27, 2024
Closed
@davidlhw davidlhw added the enhancement New user-facing feature or request. This Label is used as a category on release notes. label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaylin0312 Jaylin0312 Jaylin0312 approved these changes

Assignees

@davidlhw davidlhw

Labels
enhancement New user-facing feature or request. This Label is used as a category on release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] API Endpoint for course data by course id
2 participants
@davidlhw @Jaylin0312