-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filters with line spacing and tabs #333
Comments
I have 1.4.5 website that uses a lot of DocLister filters. |
@pmfx No. Everything should work as before. Except some situation |
OK, that's good. So why @nick0 have some issues after upgrade? His snippet code is not complicated. I'm not sure where is the answer to his question under https://github.com/AgelxNash/DocLister/releases/tag/2.4.0 |
Before, some tipsUse table alias
Don't use alias table with filter
Use addWhereList instead of content filter
DebugUse the At now back to the original callCan you change the order of the filters and check the result?
If this doesn't help, I want to see debug result before and after upgrade |
Thanks @pmfx, I appreciate the support.
I had to change 90% of my DocLister calls and a couple of DLMenu calls. If your DocLister calls are anything like mine, you will probably have to make at least some changes to a number of your calls in every site you upgrade. Took 3/4 of a day for me to fix. Hopefully I don't have to repeat this process for the next release. Thanks @AgelxNash, I appreciate the clearer examples. That has helped me to understand the new changes a little more but in my situation it still did not make a difference to question 2. The in built filters checking for an image tv stopped working in a number of my DocLister calls (but are working fine elsewhere in the site). Changing to the IF snippet fixed those and the images are now showing. Resolved, thank you for your help. Please give us a forum before v2.0 is released. Changes are being made so fast to items legacy Evo users are just getting their head around and we need somewhere we can ask questions (even questions that you may feel are too easy or obvious) without recriminations. Not everyone is a programmer or coding guru. I am hesitant to ask questions here but we have nowhere else to do it. I read that page on 2.4.0 but it does not make sense to me, I do not understand what it is talking about. It looks like MySQL to my non programming eyes. I know it makes sense to developers, but many Evo users are not programmers, myself included. We need specific examples in the docs, like what you posted in this thread - eg
There is much reading between the lines needed at the moment which requires a high level of programming expertise Thanks for the assist. |
also in the DocLister calls... this works:
but this version with line spacing and tabs (which worked before 2.4.0) does not:
whilst this with tvd removed does:
Its a little bit quirky. |
Full replacement is not needed. These were only general guidelines for using the snippet.
Both methods are equivalent. |
Let's explore how filters work
Let's take 4 examples as a basis.
What do we want to get with these filters?A1 Why did it work before with spaces?Filter parsing started from left to right. But now, right to left. So if you want to use formatting. Do not forget to put a filter separator where your filter ends. For example
|
Thanks for the super clear explanation @AgelxNash. I was under the impression that previously we needed to keep the ; off the end of the last filter statement. I have remedied that on the site and have a better understanding of usage going forward, thanks. I think perhaps the first issue I had mainly was the missing ; off the last filter statement. Such a little thing. Thanks again for the easy to understand assist |
Hello,
Has anyone else's DocLister calls stopped working after updating to 1.4.6 with DocLister 2.4.0?
I have a few calls that have stopped working. I managed to fix a couple but am stuck on a few...
I tried to make sense of the 2.4.0 notes but I don't understand if that is the reason and if so how to fix in my instances.
I tried this as an alternative but it lists all items (not taking into account med as TV selection
Any ideas on what I need to tweak for 1.4.6 to get working?
This one returns the correct documents but no images.
Is there something I need to change now for 1.4.6?
Thanks for any help.
The text was updated successfully, but these errors were encountered: