Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: creates evaluators when app is created #1955

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: creates evaluators when app is created #1955

wants to merge 7 commits into from

Conversation

Dozie2001
Copy link

@Dozie2001 Dozie2001 commented Jul 31, 2024 •
edited by jp-agenta
Loading

Description

  • This PR tackles a bug in which an exact JSON match is created with each served variant.

Changes

  • This PR removes the create_ready_to_use_evaluators() when each variant is made and rather invokes it once when the app is made.

Related Issues

QA

  • Create a first variant of an application, and check that ready-to-use evaluators were created.
  • Create a second variant of the same application, an check that no new ready-to-use evaluators were created.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 31, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024

@Dozie2001 is attempting to deploy a commit to the mmabrouk's projects Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added Backend bug Something isn't working labels Jul 31, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 7:41am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp-agenta jp-agenta jp-agenta approved these changes

Assignees
No one assigned
Labels
Backend bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dozie2001 @jp-agenta