Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the validation logic with regression validation logic, #357

Merged

Conversation

Eyobyb
Copy link
Collaborator

@Eyobyb Eyobyb commented May 3, 2024

Description

change the validation process with the regression validation which is explained here https://linear.app/aggregate-intellect/issue/SHX-59

Add directions for contributors. For example, do developers need to run poetry install after picking up these changes?

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

#SHX-59

Checklists

To speed up the review process, please follow these checklists:

Development

  • The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@Eyobyb Eyobyb force-pushed the regration-validation-logic branch from cb8213e to a14d29d Compare May 8, 2024 11:22
@Eyobyb Eyobyb requested a review from 20001LastOrder May 8, 2024 11:29
Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, please check the comments below as well as the issue about regenerated text.

src/sherpa_ai/agents/base.py Outdated Show resolved Hide resolved
src/sherpa_ai/agents/base.py Outdated Show resolved Hide resolved
src/sherpa_ai/agents/base.py Outdated Show resolved Hide resolved
src/sherpa_ai/agents/base.py Outdated Show resolved Hide resolved
src/sherpa_ai/agents/base.py Outdated Show resolved Hide resolved
src/sherpa_ai/agents/base.py Outdated Show resolved Hide resolved
src/sherpa_ai/agents/base.py Outdated Show resolved Hide resolved
src/sherpa_ai/agents/base.py Outdated Show resolved Hide resolved
src/sherpa_ai/agents/base.py Show resolved Hide resolved
@Eyobyb Eyobyb force-pushed the regration-validation-logic branch from 2b6cbca to 8c17cf4 Compare May 29, 2024 12:29
Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@20001LastOrder 20001LastOrder merged commit c17a7ae into Aggregate-Intellect:main Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants