22 login page #37
Merged
22 login page #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why it's failing the circleci build with permission denied... |
joaopapereira
requested changes
Jan 16, 2019
src/tests/containers/LogIn.test.js
Outdated
| return item.prop('name') === 'password' | ||
| }) | ||
|
|
||
| it('should have a LogIn Header', () => { |
There was a problem hiding this comment.
Not sure how valuable is this test
src/tests/containers/LogIn.test.js
Outdated
| expect(mainHeader).toHaveLength(1) | ||
| }) | ||
|
|
||
| it('should have a Form', () => { |
There was a problem hiding this comment.
Not sure how valuable is this test
src/tests/containers/LogIn.test.js
Outdated
| expect(wrapper.state().password).toBe('password') | ||
| }) | ||
|
|
||
| it('should call handleLogIn and postLogInInfo when the form is submitted', async () => { |
There was a problem hiding this comment.
I would like to see the negative test
src/tests/containers/LogIn.test.js
Outdated
| expect(wrapper.find('Form')).toHaveLength(1) | ||
| }) | ||
|
|
||
| it('should update the state when email input value changes', () => { |
There was a problem hiding this comment.
Not sure how valuable is this test
src/tests/containers/LogIn.test.js
Outdated
| expect(wrapper.state().email).toBe('existing-user@example.com') | ||
| }) | ||
|
|
||
| it('should update the state when password input value changes', () => { |
There was a problem hiding this comment.
Not sure how valuable is this test
src/containers/LogIn.js
Outdated
| iziToast.show({ | ||
| theme: 'light', | ||
| title: 'Success', | ||
| message: 'Have a look around', |
There was a problem hiding this comment.
The text on the story is:
"Welcome back, Julie"
ghost
assigned - returns an object, not an array like other components
mattwr18
added a commit
that referenced
this pull request
Jan 29, 2019
* Get basic login to rails api set up * Add styling, izitoast, success, and failure protocol * Set up redux for Login, test * Update endpoints, move test files
bryszard
pushed a commit
that referenced
this pull request
Apr 13, 2019
* Get basic login to rails api set up * Add styling, izitoast, success, and failure protocol * Set up redux for Login, test * Update endpoints, move test files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
fixes #22
Screenshots (if appropriate):
Testing
have not added integration tests, but the coverage is looking good