74 add spinner to create billing agreement #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add multiple files missing on creation
* Add UsersList container, test fixes #5
* semantic-ui assets * exclude assets folders from coverage report * add package.json * Remove separate components from repo * remove unused themes
* add path module * add build cmd * add new line * fix style loader * config files and manual for customizing semantic ui * keep only changes in site.variables * removed unused import * removed unused import from tests * add semantic folder to gitignore * add deleted test * exclude assets folders from coverage report * added assets * clean assets * Remove package-lock * Readme modification
* add path module * add build cmd * add new line * fix style loader * config files and manual for customizing semantic ui * keep only changes in site.variables * removed unused import * removed unused import from tests * add semantic folder to gitignore * add deleted test * exclude assets folders from coverage report * added assets * clean assets * add source files * add images files * add fixtures files * fix jest failing on svg import * rename page title * render hemepage * cleaned tests * remove unused import from index page * Remove extra space
* Add multiple files missing on creation - Add Issue and Pull Request template - Add License - Add Code Of conduct * Add UsersList container, test fixes #5 * Bg fix style loader (#8) * add path module * add build cmd * add new line * fix style loader * Add new lines at end of files * Add pagination, user component * Remove logic for extra links, import connected component - We don't have 42 pages right now, as we're only getting 100 users - copy and paste mistake * Add Grid, styling * semantic-ui assets (#13) * semantic-ui assets * exclude assets folders from coverage report * add package.json * Remove separate components from repo * remove unused themes * Install semantic ui (#14) * add path module * add build cmd * add new line * fix style loader * config files and manual for customizing semantic ui * keep only changes in site.variables * removed unused import * removed unused import from tests * add semantic folder to gitignore * add deleted test * exclude assets folders from coverage report * added assets * clean assets * Remove package-lock * Readme modification * Homepage (#15) * add path module * add build cmd * add new line * fix style loader * config files and manual for customizing semantic ui * keep only changes in site.variables * removed unused import * removed unused import from tests * add semantic folder to gitignore * add deleted test * exclude assets folders from coverage report * added assets * clean assets * add source files * add images files * add fixtures files * fix jest failing on svg import * rename page title * render hemepage * cleaned tests * remove unused import from index page * Remove extra space * Add UsersList container, test fixes #5 * Bg fix style loader (#8) * add path module * add build cmd * add new line * fix style loader * Add pagination, user component * Remove logic for extra links, import connected component - We don't have 42 pages right now, as we're only getting 100 users - copy and paste mistake * Add Grid, styling * Install semantic ui (#14) * add path module * add build cmd * add new line * fix style loader * config files and manual for customizing semantic ui * keep only changes in site.variables * removed unused import * removed unused import from tests * add semantic folder to gitignore * add deleted test * exclude assets folders from coverage report * added assets * clean assets * Remove package-lock * Readme modification * Fix styling for users cards
* Add initial readme instructions * Add contributing guide instructions * Minor edits to the contribution.md file * hot fix
Removed because we are using yarn to maintain the dependencies
Random changes
Correct the projects issues raise by standard Change the location of test files Use babel eslint parser with standard
currently getting a 404 not found erroq
… 39-add-paypal-payment-support
- create billing agreement failure - execute billing agreement failure
… 74-add-spinner-to-createBillingAgreement
ghost
assigned 
|
This pull request is automatically deployed with Now. |
mattwr18
force-pushed
the
74-add-spinner-to-createBillingAgreement
branch
from
6ca9793
to
f8a68fb
Compare
joaopapereira
approved these changes
Feb 18, 2019
delete-merged-branch
bot
deleted the
74-add-spinner-to-createBillingAgreement
branch
bryszard
pushed a commit
that referenced
this pull request
Apr 13, 2019
* Add spinner to Subscriptions component * Handle errors in create/execute billing agreement * Extract types, get tests passing - create billing agreement failure - execute billing agreement failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds spinner and error boundary handling
Issue addressed
fixes #74
Testing
tested at the component level
spent about an hour and a half - 2hours rebasing and still had merged conflicts, and it still needs to be squashed and merged, so yeah...