Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of null checks, use default values for class parameters #4

Closed
tadaspetra opened this issue Jun 18, 2021 · 1 comment · Fixed by #18
Closed

Instead of null checks, use default values for class parameters #4

tadaspetra opened this issue Jun 18, 2021 · 1 comment · Fixed by #18
Assignees
Labels
enhancement New feature or request

Comments

@tadaspetra
Copy link
Contributor

Describe the solution you'd like
There are some null checks within the code, that could be updated to have a default value in the data class constructor. This would make the code slightly more efficient as there would be one less null check

Describe alternatives you've considered
Just keeping the null checks, doesn't affect the code too much, would make it a little bit cleaner

@tadaspetra tadaspetra added the enhancement New feature or request label Jun 18, 2021
tadaspetra added a commit that referenced this issue Jul 7, 2021
Removes null checks when possible

closes #4
@tadaspetra
Copy link
Contributor Author

merged in #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants