Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes null checks when possible #18

Merged

Conversation

Ascenio
Copy link
Contributor

@Ascenio Ascenio commented Jul 2, 2021

Closes #4.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • The GitHub Actions pass building and linting. Linter returns no warnings or errors.
  • The QA checklist below has been completed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There are lots of null checks, mainly in SessionController. We should try to minimize that.

Issue Number: #4

What is the new behavior?

Where there were default values there's no need for null check anymore.

Does this introduce a breaking change?

  • Yes
  • No

QA Checklist

UIKit Update Checklist (Minor or Patch Release)

  • Using the latest version of Agora's Video SDK
  • Example apps are all functional
  • Core features are still working (both ways across platforms)
    • Camera + Mic muting works for local and remote users
    • Users are added and removed correctly when they join and leave the channel
    • Older versions of the library gracefully handle changes (Create issue if not)
    • Builtin buttons all work as expected
  • Any newly deprecated methods are flagged as such inline and in documentation

UIKit Update Checklist (Major Release)

  • The above checklist is completed (except backwards compatibility)
  • Thoroughly tested for crashes, across multiple platforms at the same time

@tadaspetra tadaspetra changed the base branch from main to dev July 2, 2021 18:56
@Ascenio Ascenio changed the title refactor: removes null checking when possible Removes null checking when possible Jul 2, 2021
@Ascenio Ascenio changed the title Removes null checking when possible Removes null checks when possible Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instead of null checks, use default values for class parameters
2 participants