-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the type mismatch issue while compiling. #178
Conversation
onChannelMediaRelayEvent is not defined as an instance field of the RtcEngineEventHandler any more
I've recently submitted my first pull request to the Agora UI Kit package. I've created a pull request to address the issue#177. It would be greatly appreciated if someone could review it and provide feedback. This is my first time contributing to a package, so I'm not entirely sure if everything is correct. Thank you for your attention and assistance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Release Version:
1.3.8
Release Notes
onChannelMediaRelayEvent
callback fromRtcEngineEventHandler
.Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The
onChannelMediaRelayEvent
callback was present in theRtcEngineEventHandler
class.What is the new behavior?
Removed the
onChannelMediaRelayEvent
callback as it was deprecated and no longer used.Does this introduce a breaking change?
This introduces a breaking change as the
onChannelMediaRelayEvent
callback has been removed.QA Checklist
VideoUIKit Update Checklist (Minor or Patch Release)
QA Notes
Tested across iOS and Android devices, no issues encountered.
Other information
No additional information.