Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the type mismatch issue while compiling. #178

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

muj-i
Copy link
Contributor

@muj-i muj-i commented Mar 3, 2024

Release Version:

1.3.8

Release Notes

  • Removed deprecated onChannelMediaRelayEvent callback from RtcEngineEventHandler.
  • fix the type mismatch issue while compiling.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • The GitHub Actions pass building and linting. Linter returns no warnings or errors.
  • The QA checklist below has been completed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The onChannelMediaRelayEvent callback was present in the RtcEngineEventHandler class.

What is the new behavior?

Removed the onChannelMediaRelayEvent callback as it was deprecated and no longer used.

Does this introduce a breaking change?

  • Yes
  • No

This introduces a breaking change as the onChannelMediaRelayEvent callback has been removed.

QA Checklist

VideoUIKit Update Checklist (Minor or Patch Release)

  • Using the latest version of Agora's Video SDK
  • Example apps are all functional
  • Core features are still working (both ways across platforms)
  • Camera + Mic muting works for local and remote users
  • Users are added and removed correctly when they join and leave the channel
  • Older versions of the library gracefully handle changes (Create issue if not)
  • Builtin buttons all work as expected
  • Any newly deprecated methods are flagged as such inline and in documentation

QA Notes

Tested across iOS and Android devices, no issues encountered.

Other information

No additional information.

@muj-i
Copy link
Contributor Author

muj-i commented Mar 3, 2024

I've recently submitted my first pull request to the Agora UI Kit package.

I've created a pull request to address the issue#177. It would be greatly appreciated if someone could review it and provide feedback. This is my first time contributing to a package, so I'm not entirely sure if everything is correct.

Thank you for your attention and assistance.

@muj-i muj-i closed this Mar 4, 2024
@muj-i muj-i reopened this Mar 4, 2024
@muj-i muj-i marked this pull request as draft March 4, 2024 05:07
@muj-i muj-i marked this pull request as ready for review March 4, 2024 05:28
@tadaspetra
Copy link
Contributor

Hi @muj-i I saw that issue #177 is closed and you left a comment that it is working again on 3.19.2

Copy link
Contributor

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tadaspetra tadaspetra merged commit 4cf8315 into AgoraIO-Community:main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants