Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled Video Fix and Video Render Mode #41

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Disabled Video Fix and Video Render Mode #41

merged 3 commits into from
Sep 22, 2021

Conversation

Meherdeep
Copy link
Contributor

Solves issue #35 and #36

This was linked to issues Sep 9, 2021
[BUG] disabledVideoWidget parameter only works for Floating View #35
Closed
[FEATURE] Have an option to keep the aspect ratio of remote video? #36
Closed
maxxfrazer
maxxfrazer previously approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@maxxfrazer maxxfrazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxxfrazer maxxfrazer added bug Something isn't working enhancement New feature or request labels Sep 9, 2021
@tadaspetra
Copy link
Contributor

tadaspetra commented Sep 10, 2021 •
edited

Also @Meherdeep this is merging to main we want to be merging to dev and only to main when there's a new release. Updating now to dev.

@tadaspetra tadaspetra changed the base branch from main to dev September 10, 2021 14:12
@tadaspetra tadaspetra dismissed maxxfrazer’s stale review September 10, 2021 14:12

The base branch was changed.

tadaspetra
tadaspetra approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tadaspetra tadaspetra merged commit 587bc1b into dev Sep 22, 2021
@tadaspetra tadaspetra deleted the disabled-video-fix branch September 22, 2021 17:53
@mohit41999 mohit41999 mentioned this pull request Oct 11, 2021
Closed
@SherazJamil SherazJamil mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadaspetra tadaspetra tadaspetra approved these changes

@maxxfrazer maxxfrazer maxxfrazer left review comments

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@Meherdeep @tadaspetra @maxxfrazer