Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release v0.0.3 #29

Merged
merged 33 commits into from
Jul 30, 2021
Merged

release v0.0.3 #29

merged 33 commits into from
Jul 30, 2021

Conversation

Meherdeep
Copy link
Contributor

  • Upgraded the agora_rtc_engine to v4.0.5
  • Black Screen Fix
  • Remove unnecessary null checks
  • AreaCode bug fix
  • Added roadmaps to README.md

Ascenio and others added 30 commits June 30, 2021 21:54
@Ascenio
fix: makes async functions return Future
3353349
@Ascenio
style: adds unawaited_futures linting rule
8d9e0fb
@Ascenio
fix: changes platformVersion from getter to function
832d7c1
@Ascenio
fix: removes async from sync function
4b3ff0f
@Ascenio
fix: removes async keyword from sync methods
a439a03
@Ascenio
refactor: removes null checking when possible
da94e2e
@Meherdeep
Merge pull request #15 from Ascenio/fix/awaits-for-futures
60bf026 
Fixes awaits
@Meherdeep
Merge pull request #16 from Ascenio/fix/turn-getters-into-functions
7aa6b42 
Fixes getters
@tadaspetra
Merge branch 'dev' into refactor/removes-null-checks
4a3a543
@tadaspetra
Merge pull request #18 from Ascenio/refactor/removes-null-checks
82be51e 
Removes null checks when possible

closes #4
@tadaspetra
Create dart.yml
9675a9d 
- add static analysis before merge
@Meherdeep
Merge pull request #20 from AgoraIO-Community/static-analysis
05aa905 
Github Actions for Static Analysis
@Meherdeep
fixes async/await error
32bc1ec
@tadaspetra
Merge pull request #23 from AgoraIO-Community/meher-patch-1
df43c8a 
fixes async/await error
@tadaspetra
Update dart.yml
768ae94
@tadaspetra
update test
5a60b73
@tadaspetra
Added formatting
0e9bed3
@tadaspetra
updated formatting
3e769ba
@tadaspetra
update with label passing
0dfe8bd
@Meherdeep
Merge pull request #22 from AgoraIO-Community/tadaspetra-patch-2
814225c 
Fix static analysis
@tadaspetra
added some roadmap
17ffcb1
@Meherdeep
add more roadmaps
1f9ce62
@Meherdeep
Merge pull request #24 from AgoraIO-Community/Create-Roadmap
3af44e4 
Create roadmap
@Meherdeep
black-screen-fix
22ebad5
@Meherdeep
area code fix and upgrading rtc_engine to v4.0.5
cb6a522
@Meherdeep
adding missing files
599cbe5
@Meherdeep
Merge pull request #27 from AgoraIO-Community/areacode-fix
ae00436 
area code fix and upgrading rtc_engine to v4.0.5
@Meherdeep
Merge branch 'black-screen-fix' into dev
61ecc29
@Meherdeep
Merge pull request #25 from AgoraIO-Community/black-screen-fix
8258c91 
black-screen-fix
@Meherdeep
moving to v0.0.3
3c45936
tadaspetra
tadaspetra approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

maxxfrazer
maxxfrazer approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@maxxfrazer maxxfrazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, changes make the code a lot neater too, LGTM

@Meherdeep Meherdeep merged commit e7ffb56 into main Jul 30, 2021
@mohit41999 mohit41999 mentioned this pull request Oct 11, 2021
Closed
@SherazJamil SherazJamil mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxxfrazer maxxfrazer maxxfrazer approved these changes

@tadaspetra tadaspetra tadaspetra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Meherdeep @maxxfrazer @tadaspetra @Ascenio