Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v0.0.4 #50

Merged
merged 36 commits into from
Oct 7, 2021
Merged

release v0.0.4 #50

merged 36 commits into from
Oct 7, 2021

Conversation

Meherdeep
Copy link
Contributor

  • New method of initialising the SDK
  • Fixing the Event Handler class (Not all the event handlers are required)
  • Build test for Android and iOS
  • Added fix for disabled video in grid view

Copy link
Contributor

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@maxxfrazer maxxfrazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, @Meherdeep @tadaspetra let me know if you think this is a bad dart practice or not. But by an estimate, it would reduce the size of the file by a couple of hundred lines removing all those if statements

lib/controllers/session_controller.dart Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants