enhance smart wallet behavior when invitation creation fails #9239
Assignees
Labels
Comments
This was referenced Apr 16, 2024
mergify bot
added a commit
that referenced
this issue
Apr 18, 2024
…itation (#9236) refs: #9239 ## Description test handling payments in case of failure to create invitation; incorporate fix from ... - #9240 ### Security / Scaling / Documentation n/a ### Upgrade Considerations deployment involves upgrading walletFactory (see #9238) ### Testing Considerations swingsetTest (and thus walletDriver) doesn't provide access to balances, so bootstrap test was removed from this PR
gibson042
pushed a commit
that referenced
this issue
Apr 19, 2024
…itation (#9236) refs: #9239 ## Description test handling payments in case of failure to create invitation; incorporate fix from ... - #9240 ### Security / Scaling / Documentation n/a ### Upgrade Considerations deployment involves upgrading walletFactory (see #9238) ### Testing Considerations swingsetTest (and thus walletDriver) doesn't provide access to balances, so bootstrap test was removed from this PR
gibson042
pushed a commit
that referenced
this issue
Apr 19, 2024
closes: #9239 ~~stacked on #9236~~ ## Description - [x] feat(smart-wallet): tryExitOffer reclaims withdrawn payments - [x] logs reclaimed balances - [x] upgrade core-eval, app.go - [x] feat: tryExitOffer CLI tool - [x] a3p-integration test: bad offer in prepare; test exitOffer tool in test phase ### Security / Scaling Considerations Using `tryExitOffer` to trigger reclaim results in an irrelevant diagnostic that's possibly misleading: ``` 2024-04-18T21:32:20.809Z SwingSet: ls: v43: Error#1: key bad-invitation-15 not found in collection live offer seats ``` ### Documentation Considerations the `exitOffer.js` tool is in sort of a strange place ### Testing Considerations e2e test coverage seems good. The unit test from #9236 doesn't cover this feature well because it doesn't run in the before-upgrade world ### Upgrade Considerations needs cherry-picking
gibson042
pushed a commit
that referenced
this issue
Apr 19, 2024
…itation (#9236) refs: #9239 ## Description test handling payments in case of failure to create invitation; incorporate fix from ... - #9240 ### Security / Scaling / Documentation n/a ### Upgrade Considerations deployment involves upgrading walletFactory (see #9238) ### Testing Considerations swingsetTest (and thus walletDriver) doesn't provide access to balances, so bootstrap test was removed from this PR
gibson042
pushed a commit
that referenced
this issue
Apr 19, 2024
closes: #9239 ~~stacked on #9236~~ ## Description - [x] feat(smart-wallet): tryExitOffer reclaims withdrawn payments - [x] logs reclaimed balances - [x] upgrade core-eval, app.go - [x] feat: tryExitOffer CLI tool - [x] a3p-integration test: bad offer in prepare; test exitOffer tool in test phase ### Security / Scaling Considerations Using `tryExitOffer` to trigger reclaim results in an irrelevant diagnostic that's possibly misleading: ``` 2024-04-18T21:32:20.809Z SwingSet: ls: v43: Error#1: key bad-invitation-15 not found in collection live offer seats ``` ### Documentation Considerations the `exitOffer.js` tool is in sort of a strange place ### Testing Considerations e2e test coverage seems good. The unit test from #9236 doesn't cover this feature well because it doesn't run in the before-upgrade world ### Upgrade Considerations needs cherry-picking
raphdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
Currently smart-wallet lacks tests for failure to create invitation. This is a failure we want to handle to ensure we're handling invitations correctly in the smart wallet.
Description of the Design
Security Considerations
Scaling Considerations
Test Plan
Have test coverage for more edge cases.
Upgrade Considerations
Tasks
The text was updated successfully, but these errors were encountered: