Ivan/8876-pfm-on-chain #8969
Closed
Ivan/8876-pfm-on-chain #8969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add per the Integration Guide - https://github.com/cosmos/ibc-apps/blob/middleware/packet-forward-middleware/v6.1.1/middleware/packet-forward-middleware/docs/integration.md At this point, the integrated change built locally after `go mod tidy` to pull in new dependencies No testing has been run yet. Version Choice: * PFM v6.1.1 - https://github.com/cosmos/ibc-apps/releases/tag/middleware%2Fpacket-forward-middleware%2Fv6.1.1 * go.mod - https://github.com/cosmos/ibc-apps/blob/middleware/packet-forward-middleware/v6.1.1/middleware/packet-forward-middleware/go.mod * Cosmos-SDK v0.46.15 * IBC-Go v6.2.0 * Tendermint v0.34.29 * Works with agoric-sdk versions * go,mod - https://github.com/Agoric/agoric-sdk/blob/master/golang/cosmos/go.mod * Cosmos-SDK v0.46.16 * github.com/cosmos/cosmos-sdk => github.com/agoric-labs/cosmos-sdk v0.46.16-alpha.agoric.1 * IBC-Go v6.2.1 * Tendermint v0.34.29 * github.com/tendermint/tendermint => github.com/agoric-labs/cometbft v0.34.30-alpha.agoric.1
The Strangelove Interchain Test - https://github.com/strangelove-ventures/interchaintest - https://strange.love/blog/announcing-interchaintest allows for spinning up docker images representing chains - like osmosis or cosmoshub - and IBC relayers - like the go relayer or hermes - and then connecting them all together and testing IBC, ICA, PFM conformance. This change adds a new agoricinterchain package that runs basic conformace tests against osmosis & the hub. To run the tests `make interchaintest` from `agoricinterchain/`. Example output here: https://gist.github.com/ivanlei/6275c67ffd19204a127139b18b97c612 The major challenge with this commit was finding a good set of go.mod replace directives to get everything building. My next commit should add agoric to the test mix.
…ding to specify an argument to `make`
…r like: `failed to load latest version: version of store packetfowardmiddleware mismatch root store's version; expected 1337 got 0` Found cosmos/cosmos-sdk#16003 which hinted "Probably forgot to configure the store upgrades in a upgrade that added this store." The upgrade guide for PFM didn't mention this but I got lucky and remembered the `Delete` block about `x/crisis`. Created an `Added` block in the same place and things got happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7712
refs: #8878
Description
Adds PR feedback from #8878
Like a derp who never codes around here, I had tagged my PR with mergify labels and then got an approval on my PR so I couldn't update the branch before mergify grabbed it and merged away.
These changes based on PR feedback are largely cosmetic or doc correctness, not functionally impactful.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations