8868 gen submissions #9009
Merged
8868 gen submissions #9009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@turadg, It's confused about the commits. I'll rebase and fix it. |
Chris-Hibbert
force-pushed
the
8868-gen-submissions
branch
from
273bbf5
to
29e16b0
Compare
turadg
reviewed
Feb 28, 2024
| @@ -23,7 +23,8 @@ | |||
| ] | |||
| }, | |||
| "scripts": { | |||
| "agops": "yarn --cwd /usr/src/agoric-sdk/ --silent agops" | |||
| "agops": "yarn --cwd /usr/src/agoric-sdk/ --silent agops", | |||
| "build:submission": "../../../scripts/generate-a3p-submission.sh probe-zcf-bundle a:upgrade-next probeZcfBundle probe-submission" | |||
There was a problem hiding this comment.
the proposal package must not take a dependency on SDK scripts.
What you could do instead is put these params into agoricProposal and have the top-level script read those to know what to build.
There was a problem hiding this comment.
Here's another try. It required extra escaping because of directory names containing dashes.
Chris-Hibbert
force-pushed
the
8868-gen-submissions
branch
from
674fcd5
to
67d88f3
Compare
turadg
reviewed
Feb 29, 2024
| @@ -6,6 +6,8 @@ | |||
| "upgradeInfo": { | |||
| "coreProposals": [] | |||
| }, | |||
| "submission": "probe-zcf-bundle", | |||
| "probe-zcf-bundle": "a:upgrade-next probeZcfBundle probe-submission", | |||
There was a problem hiding this comment.
a:upgrade-next is implied by the proposal package.
There was a problem hiding this comment.
Let's also be clear that this isn't part of the synthetic-chain API.
"sdk-generate": [
"probe-zcf-bundle probeZcfBundle probe-submission"
]
a3p-integration/package.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "scripts": { | |||
| "build": "yarn run build:sdk && yarn run build:submission && yarn run build:synthetic-chain", | |||
| "build:sdk": "make -C ../packages/deployment docker-build-sdk", | |||
| "build:submission": "../scripts/generate-a3p-submission.sh", | |||
| "build:submission": "../scripts/generate-a3p-submission-dirs.sh", | |||
Comment on lines
5
to
6
| "submission": "test-localchain", | ||
| "test-localchain": "b:localchain" |
There was a problem hiding this comment.
Suggested change
| "submission": "test-localchain", | |
| "test-localchain": "b:localchain" | |
| "sdk-generate": [ | |
| "test-localchain" | |
| ] |
Chris-Hibbert
force-pushed
the
8868-gen-submissions
branch
from
5a1226a
to
c0dece4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: a3p#87
refs: 8868
Description
Rather than requiring every new core-eval proposal to edit
generate-a3p-submission.sh, each proposal can add details to its package.json, and all required submissions will be generated from that.Security Considerations
None: internal tooling only
Scaling Considerations
None: internal tooling only
Documentation Considerations
Added comments in some of the READMEs
Testing Considerations
Verified it worked on #8911
Upgrade Considerations
This is support for testing upgrades. It doesn't involve any code on chain.