refactor: exofy Orchestrator, RemoteChainFacade #9529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
8f1c7bd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d6d4a5f7.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-orch-exos.agoric-sdk.pages.dev |
0xpatrickdev
approved these changes
Jun 19, 2024
dtribble
approved these changes
Jun 19, 2024
| { | ||
| /** @type {Orchestrator['getChain']} */ | ||
| getChain: async name => { | ||
| const agoricChainInfo = await chainHub.getChainInfo('agoric'); |
There was a problem hiding this comment.
do these need to all be vow-based?
(I'm hoping not)
There was a problem hiding this comment.
No, they're awaiting at most a remote call to a synchronous method on agoricNames, so they will quiesce in any vat upgrade
|
|
||
| const address = await V(icaAccount).getAddress(); | ||
|
|
||
| const [{ denom: bondDenom }] = remoteChainInfo.stakingTokens || [ |
| @@ -59,12 +61,28 @@ export const provideOrchestration = ( | |||
| vowTools, | |||
| }); | |||
|
|
|||
| const makeCosmosOrchestrationAccount = prepareCosmosOrchestrationAccount( | |||
| // XXX what zone? | |||
|
I'll merge now in service of integration and follow up quickly to satisfy requests. |
mergify bot
added a commit
that referenced
this pull request
Jun 19, 2024
refs: #9281 ## Description AsyncFlow requires that everything passing the membrane is durable. This makes the facade objects durable to conform. Following #9529 ### Security Considerations none ### Scaling Considerations Exo for each chain and each account ### Documentation Considerations none ### Testing Considerations Existing coverage ### Upgrade Considerations not yet deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9281
Description
AsyncFlow requires that everything passing the membrane is durable. This makes the facade objects durable to conform.
Doing so for
localChainFacadeis deferred so we can get this into master sooner, to aid @erights 's #9521 .Security Considerations
none
Scaling Considerations
Exo for each chain and each account
Documentation Considerations
none
Testing Considerations
Existing coverage
Upgrade Considerations
none, not yet deployed