This repository has been archived by the owner on Jun 15, 2024. It is now read-only.
chore: node 16 is EOL #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
force-pushed
the
chore/node-compat
branch
2 times, most recently
from
af8efa1
to
3ca2cf9
Compare
turadg
reviewed
Jan 26, 2024
| @@ -13,7 +13,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node-version: [16] | |||
| node-version: [18.x] | |||
There was a problem hiding this comment.
this should match what "engines" declares (given that GHA always picks the latest release)
Suggested change
| node-version: [18.x] | |
| node-version: [18.x, 20.x] |
There was a problem hiding this comment.
Seems like 20.x is blocked until agoric-sdk updates its own engines:
error @agoric/sdk@: The engine "node" is incompatible with this module. Expected version "^16.13 || ^18.12". Got "20.11.0"Do we feel engines is adding value in this repo? Would it be better to remove this field and inherit from agoric-sdk?
There was a problem hiding this comment.
Ah, so it is. Let's leave 20.x out for now.
Would it be better to remove this field and inherit from agoric-sdk?
Good idea. These doesn't have any narrower constraints, tmk
turadg
approved these changes
Jan 26, 2024
0xpatrickdev
force-pushed
the
chore/node-compat
branch
from
b4b14ea
to
c6973f9
Compare
0xpatrickdev
force-pushed
the
chore/node-compat
branch
from
c6973f9
to
ea8426b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: Agoric/agoric-sdk#8636