Skip to content
This repository has been archived by the owner on Jun 15, 2024. It is now read-only.

chore: node 16 is EOL #72

Merged
merged 1 commit into from
Jan 28, 2024
Merged

chore: node 16 is EOL #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16]
node-version: [18.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should match what "engines" declares (given that GHA always picks the latest release)

Suggested change
node-version: [18.x]
node-version: [18.x, 20.x]

Copy link
Member Author

@0xpatrickdev 0xpatrickdev Jan 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like 20.x is blocked until agoric-sdk updates its own engines:

error @agoric/sdk@: The engine "node" is incompatible with this module. Expected version "^16.13 || ^18.12". Got "20.11.0"

Do we feel engines is adding value in this repo? Would it be better to remove this field and inherit from agoric-sdk?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so it is. Let's leave 20.x out for now.

Would it be better to remove this field and inherit from agoric-sdk?

Good idea. These doesn't have any narrower constraints, tmk

steps:
- name: Checkout dapp
uses: actions/checkout@v2
Expand Down
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
"version": "0.0.1",
"private": true,
"useWorkspaces": true,
"engines": {
"node": ">=16.19.1"
},
"workspaces": [
"api",
"contract",
Expand Down
Loading