Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome incorrectly flagging underlying IPFS hash as 'dangerous site' when you attempt to access via app.inter.trade #299

Closed
otoole-brendan opened this issue Jun 4, 2024 · 1 comment · Fixed by #300
Closed

Chrome incorrectly flagging underlying IPFS hash as 'dangerous site' when you attempt to access via app.inter.trade #299

otoole-brendan opened this issue Jun 4, 2024 · 1 comment · Fixed by #300
Assignees
@samsiegart
Labels
bug Something isn't working

Comments

@otoole-brendan
Copy link

Describe the bug

Chrome is flagging the .dweb.link-appended IPFS hash as 'Dangerous' as of Monday 3rd June.

To Reproduce

Steps to reproduce the behavior:

  1. Go to app.inter.trade
  2. See resolution to IPFS hash
  3. See error/dangerous site message

Expected behavior

Should not be flagged as dangerous

Screenshots

image
@otoole-brendan otoole-brendan added the bug Something isn't working label Jun 4, 2024
@otoole-brendan
Copy link
Author

Quickest way to resolve is for EC to push new hash which requires a dapp-inter change before DCF can deploy to IPFS and get a new hash. @samsiegart assigning to you to complete that action.

samsiegart added a commit that referenced this issue Jun 4, 2024
@samsiegart
feat: trivially change price feed error message
ab59118 
fixes #299
@samsiegart samsiegart mentioned this issue Jun 4, 2024
Merged
rabi-siddique pushed a commit that referenced this issue Jun 7, 2024
@samsiegart @rabi-siddique
feat: trivially change price feed error message
e51eb57 
fixes #299
rabi-siddique pushed a commit that referenced this issue Jun 7, 2024
@samsiegart @rabi-siddique
feat: trivially change price feed error message
40f3c2f 
fixes #299
@otoole-brendan otoole-brendan mentioned this issue Jun 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsiegart samsiegart

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: trivially change price feed error message Agoric/dapp-inter
2 participants
@samsiegart @otoole-brendan