Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trivially change price feed error message #300

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

samsiegart
Copy link
Collaborator

fixes #299

Copy link

github-actions bot commented Jun 4, 2024

Network:
Commit: f203883
Ref: refs/heads/main
IPFS v1 hash: bafybeib5d4jztfnwprgtshwvbwyoyz443igkxogywckhm3vpvlktbi26n4
CF - DWeb - 4EVERLAND

@samsiegart samsiegart enabled auto-merge June 4, 2024 17:27
@samsiegart samsiegart merged commit f203883 into main Jun 4, 2024
4 checks passed
@samsiegart samsiegart deleted the samsiegart-patch-1 branch June 4, 2024 20:21
@@ -74,7 +74,7 @@ const watchPriceFeeds = (prefix: string) => {
.getState()
.setPriceError(
brand,
new Error('Unexpected error, price feed missing'),
new Error('Unexpected error, price feed missing.'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For want of a dot, the hash was lost

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear for posterity, a new hash was the goal (I couldn't find anywhere to put a nail 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants