Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci for getting started with dapp-offer-up, docker-compose #48

Closed
aj-agoric opened this issue Jan 23, 2024 · 1 comment · Fixed by #70
Closed

ci for getting started with dapp-offer-up, docker-compose #48

aj-agoric opened this issue Jan 23, 2024 · 1 comment · Fixed by #70
Assignees

Comments

@aj-agoric
Copy link
Collaborator

aj-agoric commented Jan 23, 2024

This issue is related to Agoric/agoric-sdk#8381 but not the same

From high level, we want two kinds of testing:

  1. testing the behavior of init subcommand of packages/agoric-cli in agoric-sdk repo
    1. so that we have test coverage even if the behavior of init subcommand changed in a PR in the future
    2. this is getting-started CI test should actually track Getting Started docs agoric-sdk#8381 and is done
  2. testing the behavior of init subcommand of https://www.npmjs.com/package/agoric, i.e. the agoric-cli that's published to npmjs.com
    1. so that the workflow as documented in https://docs.agoric.com/guides/getting-started/ is working for developers reading this doc
    2. this is ci for getting started with dapp-offer-up, docker-compose #48(this issue) and is not yet prioritized

Ref: Agoric/agoric-sdk#8829 (comment)


Edit by @LuqiPan

@aj-agoric aj-agoric transferred this issue from Agoric/agoric-sdk Jan 23, 2024
@ivanlei ivanlei assigned LuqiPan and unassigned ivanlei Feb 3, 2024
@ivanlei ivanlei changed the title ci for getting started with dapp-game-places, docker-compose ci for getting started with dapp-offer-up, docker-compose Feb 3, 2024
@LuqiPan
Copy link
Contributor

LuqiPan commented Mar 20, 2024

For reference, here's how to do it: Agoric/dapp-agoric-basics#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants