Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci does not run yarn test #77

Closed
2 tasks done
dckc opened this issue Apr 18, 2024 · 1 comment · Fixed by #78
Closed
2 tasks done

ci does not run yarn test #77

dckc opened this issue Apr 18, 2024 · 1 comment · Fixed by #78

Comments

@dckc
Copy link
Member

dckc commented Apr 18, 2024 •
edited
Loading

it got dropped: https://github.com/Agoric/dapp-offer-up/pull/73/files#r1550068488

I see why:

  • it invokes e2e tests without supplying relevant context
    • yarn test --exclude '**/e2e/**' seems to address that, but...
  • the ui/ tests hang in watch mode

cc @0xpatrickdev @rabi-siddique @LuqiPan @turadg @samsiegart
@0xpatrickdev
Copy link
Member

the ui/ tests hang in watch mode

It should not run in watch mode during CI, only locally. Try CI=true yarn test --exclude "**/e2e/**" to simulate a CI run.

https://vitest.dev/config/#watch

@dckc dckc mentioned this issue Apr 18, 2024
Merged
@dckc dckc closed this as completed in #78 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: restore yarn test, excluding e2e; restore node LTS Agoric/dapp-offer-up
2 participants
@dckc @0xpatrickdev