Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a fill param to summary #9

Merged
merged 2 commits into from
Jan 29, 2019
Merged

adding a fill param to summary #9

merged 2 commits into from
Jan 29, 2019

Conversation

matheusmota
Copy link
Contributor

No description provided.

LucasRGoes
LucasRGoes requested changes Jan 29, 2019
View reviewed changes
Copy link
Member

@LucasRGoes LucasRGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a need to change resolve fill to accept integers as the Number strategy

LucasRGoes
LucasRGoes approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@LucasRGoes LucasRGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats all right!

@LucasRGoes LucasRGoes merged commit 2d3d1f5 into master Jan 29, 2019
@LucasRGoes LucasRGoes deleted the feature/summary_fill branch January 29, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasRGoes LucasRGoes LucasRGoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matheusmota @LucasRGoes