auto update feature for release #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About Previous Controller is located in IPC communication logic, So controller subscribe action about only renderer process to main process. It is improved that controller subscribe every action whaterver main to main or renderer to renderer. ## Issue When improve Controller, We have global import module issue. Some local module like `components/i18n/index.js` and `store/createStore` is using both process that main and renderer. It doesn't matter because we write a code conditionally if it is used in main process or renderer process. But globally `import` make error. For example, `store/storeMain.js` must use only main process. But It imported in renderer process although not using. That make error, not using but import!, So we solve that conditionally import using `require` in ES5.
need to add about promise test
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Auto Update feature using
electron-updaterandgithub release api.#84
Bug
In MacOS, when download new version and restart for install downloaded file, It doesn't patch new version immediately. It update restart on manual.
I think that It is issue about
electron-updater. Refer to electron-updater #2317 issue