Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Feature: add PartExtractor api #45

Merged
merged 1 commit into from
Jan 2, 2023
Merged

- Feature: add PartExtractor api #45

merged 1 commit into from
Jan 2, 2023

Conversation

Ahoo-Wang
Copy link
Owner

Changes proposed in this pull request:

  • Feature: add PartExtractor api
  • Feature: add PartConditionMatcher api
  • Feature: enhance Request.method api
  • Feature: enhance ActionMatcher api
  • Feature: enhance InConditionMatcher

- Feature: add `PartConditionMatcher` api
- Feature: enhance `Request.method` api
- Feature: enhance `ActionMatcher` api
- Feature: enhance `InConditionMatcher`
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #45 (fe05397) into main (3ae5bff) will increase coverage by 0.20%.
The diff coverage is 86.07%.

@@             Coverage Diff              @@
##               main      #45      +/-   ##
============================================
+ Coverage     89.27%   89.48%   +0.20%     
- Complexity      394      401       +7     
============================================
  Files           130      133       +3     
  Lines          1203     1227      +24     
  Branches         72       74       +2     
============================================
+ Hits           1074     1098      +24     
+ Misses           81       80       -1     
- Partials         48       49       +1     
Flag Coverage Δ
unittests 89.48% <86.07%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...otlin/me/ahoo/cosec/api/context/request/Request.kt 0.00% <ø> (ø)
...ec/authentication/DefaultAuthenticationProvider.kt 88.88% <ø> (ø)
...osec/policy/action/ActionMatcherFactoryProvider.kt 76.47% <0.00%> (-4.78%) ⬇️
...olicy/condition/ConditionMatcherFactoryProvider.kt 76.47% <0.00%> (-4.78%) ⬇️
...condition/context/AuthenticatedConditionMatcher.kt 100.00% <ø> (ø)
...ndition/context/InDefaultTenantConditionMatcher.kt 100.00% <ø> (ø)
...dition/context/InPlatformTenantConditionMatcher.kt 100.00% <ø> (ø)
.../condition/context/InUserTenantConditionMatcher.kt 100.00% <ø> (ø)
...lin/me/ahoo/cosec/policy/DefaultPolicyEvaluator.kt 77.77% <50.00%> (-4.58%) ⬇️
.../ahoo/cosec/policy/action/AbstractActionMatcher.kt 50.00% <50.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Ahoo-Wang Ahoo-Wang merged commit ae16562 into main Jan 2, 2023
@Ahoo-Wang Ahoo-Wang deleted the PartExtractor branch January 2, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant